标签:Task await task Executing tasks async other parallel
Executing tasks in parallel
问题
Ok, so basically I have a bunch of tasks (10) and I want to start them all at the same time and wait for them to complete. When completed I want to execute other tasks. I read a bunch of resources about this but I can't get it right for my particular case...
Here is what I currently have (code has been simplified):
public async Task RunTasks()
{
var tasks = new List<Task>
{
new Task(async () => await DoWork()),
//and so on with the other 9 similar tasks
}
Parallel.ForEach(tasks, task =>
{
task.Start();
});
Task.WhenAll(tasks).ContinueWith(done =>
{
//Run the other tasks
});
}
//This function perform some I/O operations
public async Task DoWork()
{
var results = await GetDataFromDatabaseAsync();
foreach (var result in results)
{
await ReadFromNetwork(result.Url);
}
}
So my problem is that when I'm waiting for tasks to complete with the WhenAll
call, it tells me that all tasks are over even though none of them are completed. I tried adding Console.WriteLine
in my foreach
and when I have entered the continuation task, data keeps coming in from my previous Task
s that aren't really finished.
What am I doing wrong here?
回答1
You should almost never use the Task
constructor directly. In your case that task only fires the actual task that you can't wait for.
You can simply call DoWork
and get back a task, store it in a list and wait for all the tasks to complete. Meaning:
tasks.Add(DoWork());
// ...
await Task.WhenAll(tasks);
However, async methods run synchronously until the first await on an uncompleted task is reached. If you worry about that part taking too long then use Task.Run
to offload it to another ThreadPool
thread and then store that task in the list:
tasks.Add(Task.Run(() => DoWork()));
// ...
await Task.WhenAll(tasks);
回答2
If you want to run those task's parallel in different threads using TPL you may need something like this:
public async Task RunTasks()
{
var tasks = new List<Func<Task>>
{
DoWork,
//...
};
await Task.WhenAll(tasks.AsParallel().Select(async task => await task()));
//Run the other tasks
}
These approach parallelizing only small amount of code: the queueing of the method to the thread pool and the return of an uncompleted Task
. Also for such small amount of task parallelizing can take more time than just running asynchronously. This could make sense only if your tasks do some longer (synchronous) work before their first await.
For most cases better way will be:
public async Task RunTasks()
{
await Task.WhenAll(new []
{
DoWork(),
//...
});
//Run the other tasks
}
To my opinion in your code:
-
You should not wrap your code in
Task
before passing toParallel.ForEach
. -
You can just
await
Task.WhenAll
instead of usingContinueWith
.
回答3
Essentially you're mixing two incompatible async paradigms; i.e. Parallel.ForEach()
and async-await
.
For what you want, do one or the other. E.g. you can just use Parallel.For[Each]()
and drop the async-await altogether. Parallel.For[Each]()
will only return when all the parallel tasks are complete, and you can then move onto the other tasks.
The code has some other issues too:
-
you mark the method async but don't await in it (the await you do have is in the delegate, not the method);
-
you almost certainly want
.ConfigureAwait(false)
on your awaits, especially if you aren't trying to use the results immediately in a UI thread.
回答4
The DoWork
method is an asynchronous I/O method. It means that you don't need multiple threads to execute several of them, as most of the time the method will asynchronously wait for the I/O to complete. One thread is enough to do that.
public async Task RunTasks()
{
var tasks = new List<Task>
{
DoWork(),
//and so on with the other 9 similar tasks
};
await Task.WhenAll(tasks);
//Run the other tasks
}
You should almost never use the Task
constructor to create a new task. To create an asynchronous I/O task, simply call the async
method. To create a task that will be executed on a thread pool thread, use Task.Run
. You can read this article for a detailed explanation of Task.Run
and other options of creating tasks.
标签:Task,await,task,Executing,tasks,async,other,parallel 来源: https://www.cnblogs.com/chucklu/p/16443995.html
本站声明: 1. iCode9 技术分享网(下文简称本站)提供的所有内容,仅供技术学习、探讨和分享; 2. 关于本站的所有留言、评论、转载及引用,纯属内容发起人的个人观点,与本站观点和立场无关; 3. 关于本站的所有言论和文字,纯属内容发起人的个人观点,与本站观点和立场无关; 4. 本站文章均是网友提供,不完全保证技术分享内容的完整性、准确性、时效性、风险性和版权归属;如您发现该文章侵犯了您的权益,可联系我们第一时间进行删除; 5. 本站为非盈利性的个人网站,所有内容不会用来进行牟利,也不会利用任何形式的广告来间接获益,纯粹是为了广大技术爱好者提供技术内容和技术思想的分享性交流网站。